-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Sample Searching using SearchKick (Part One) #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericenns
changed the title
Feat: Advanced Sample Searching using SearchKick (Part One)
Feat: Sample Searching using SearchKick (Part One)
Nov 20, 2024
ericenns
force-pushed
the
searchkick
branch
4 times, most recently
from
November 27, 2024 20:29
82ce434
to
31e55b9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ericenns
force-pushed
the
searchkick
branch
3 times, most recently
from
December 11, 2024 22:46
9d191db
to
a161fb6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…exing and update Samples table to use Searchkick
This comment has been minimized.
This comment has been minimized.
…opensearch instructions.
…type option to select between ransack and searchkick
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Code coverage of files in pull request scope (96.1%)
Reported by octocov |
ChrisHuynh333
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
joshsadam
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Describe in detail what your merge request does and why.
In preparation for searching samples via complex metadata criteria, this PR adds in Searchkick as a dependency which uses OpenSearch (An open source ElasticSearch alternative) to index our Samples including metadata which allows complex querying. This PR just updates the Sample model to include indexing and updates the existing Project and Group Samples table to use SearchKick to perform the existing searches.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
README.md
to setup opensearchVerify migration to index existing Samples
main
branch reset the database withbin/rails db:reset
bin/rails db:migrate
Verify db/seeds.rb creates indexes for Samples
bin/rails db:reset
Verify that Samples table loads on an empty database after creating a new Project
bin/rails db:drop db:create db:migrate
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.